Okay
  Public Ticket #2540552
Category View: Classic Menu Logo disappears upon scrolling back up.
Closed

Comments

  • Westley started the conversation
    September 15, 2020 at 11:37pm

    Steps to reproduce

    1. Visit https://demo.sonaar.io/podcastr-elementor/category/general/
    2. Scroll down (logo goes to mini logo state)
    3. Scroll back to the top (logo is replaced by a broken image)

    This issue lies sonaar/classic-menu/js/classic.js (line 128).  The conditional is check for `page_logo_select` not equal to false.  On a category page, it looks like the `page_logo_select` is equal to `null`.  The condition needs to be improved to test for whether the variable is set first, and then if its equal to false.

    sonaar/classic-menu/js/classic.js:128

    var logoSelect = (IRON.state.logo.page_logo_select !== false) ? IRON.state.logo.page_logo_select : IRON.state.logo.logo_select


    A similar condition exists on line 25 that seems to work better:

    sonaar/classic-menu/js/classic.js:25

    var logoSelect = (IRON.state.logo.page_logo_select === "dark" || IRON.state.logo.page_logo_select === "light") ? IRON.state.logo.page_logo_select : IRON.state.logo.logo_select
  •  667
    Alexandre replied
    September 16, 2020 at 4:06pm

    Thanks a lot, 
    This issue is already fixed but we have not released it yet. 
    The next theme update will fix this. 
    But thanks again. Your help is very appreciated

    Thanks,

    Alexandre from the Sonaar.io Crew